Feature/#130 custom enum field#147
Merged
ikbendewilliam merged 43 commits intofeature/#135-map-with-listfrom Sep 15, 2023
Merged
Feature/#130 custom enum field#147ikbendewilliam merged 43 commits intofeature/#135-map-with-listfrom
ikbendewilliam merged 43 commits intofeature/#135-map-with-listfrom
Conversation
Contributor
|
Tested this: and it gave me this: |
Contributor
|
rename |
vanlooverenkoen
suggested changes
Sep 7, 2023
| 'generate_extensions is removed, follow the migration to version 7.0.0'); | ||
| } | ||
|
|
||
| final deprecatedGenerateMap = value['generate_map']; |
Contributor
There was a problem hiding this comment.
Why is this deprecated? Because the map is still needed. but it should use the values fields from the enum values instead. Otherwise we will have to write our own mapping each time we want to map something. Keeping this logic will make it the same for all projects
Fix/issues
Contributor
|
There is an issue with the lowercasing in enum names inBrowser:
properties:
value: inBrowser @JsonValue('inBrowser')
inbrowser(
value: 'inBrowser',
);I would expect inbrowser to still have a capital B |
ikbendewilliam
suggested changes
Sep 14, 2023
Contributor
ikbendewilliam
left a comment
There was a problem hiding this comment.
See comment in conversation
ikbendewilliam
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #130